sign bulk psbts #42
sign bulk psbts #42
Conversation
src/transactions/types.ts
Outdated
|
|
||
| export interface SignMultipleTransactionsPayload extends RequestPayload { | ||
| message: string; | ||
| psbts: PsbtPayload[]; |
There was a problem hiding this comment.
Just checking on this, do we expect some psbts to have broadcast set to true and some to false or should boroadcast maybe be pulled out of the PsbtPayload type?
There was a problem hiding this comment.
yeah this was the point i brought up during the daily before maybe @yknl can chime in on that one
There was a problem hiding this comment.
also only passing an address without specifying and index
There was a problem hiding this comment.
We should pull it out. Having some transactions broadcasted and some not would be bad UX. Developers can always make another request for transactions that they don't intend to broadcast immediately.
There was a problem hiding this comment.
@m-aboelenein will you change the interface here so that broadcast boolean property is related to all of the psbts sent to sign?
@dhriaznov interface updated |
|
teebszet
deleted the
mahmoud/eng-2877-batch-sign-psbt-in-sats-connect
branch
No description provided.